[Differential] [Accepted] D3512: Show uses for __call__() and __{get,set}item__()
brauch (Sven Brauch)
noreply at phabricator.kde.org
Sat Nov 26 01:54:14 UTC 2016
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Looks good to me. Feel free to rename things, esp. lots of functions could really have better names. Using what is now called functionDeclarationForCalledDeclaration in more places sounds very sensible as well.
As a regression test by the way, I recommend downloading a large python project (e.g. pypy) and just running duchainify on it (built in debug). That is quite good in triggering obscure crashes.
Very nice of you to tidy this up!
REPOSITORY
rKDEVPYTHON KDev-python
REVISION DETAIL
https://phabricator.kde.org/D3512
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: flherne, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161126/d9091af1/attachment.html>
More information about the KDevelop-devel
mailing list