[Differential] [Changed Subscribers] D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager

[mwolff (Milian Wolff)]

mwolff added inline comments.

INLINE COMMENTS

> zhigalin wrote in colorschemechooser.h:34
> What is this?

It is a so called forward declaration. We don't actually need to know the ins and outs of how this class looks like, just that it exists somewhere.

> zhigalin wrote in colorschemechooser.h:63
> null pointer is required?

it's good practice to make sure the value is properly initialized. otherwise, it will contain random uninitialized memory garbage

> zhigalin wrote in colorschemechooser.h:66
> const?

yes, it's a getter and does not mutate the observable state of this object. thus it should be const

> zhigalin wrote in colorschemechooser.h:67
> Why const & here?

that is following the Qt coding guidelines, which says that you take nearly all (except small) values by const&. Not doing so would incur a copy operation, which may be expensive.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kdevelop, zhigalin
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160720/f2534aea/attachment.html>