[Differential] [Commented On] D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager

[zhigalin (Alexander Zhigalin)]

zhigalin added inline comments.

INLINE COMMENTS

> colorschemechooser.h:34
> +
> +class KActionCollection;
> +

What is this?

> colorschemechooser.h:63
> +    private:
> +        KActionMenu*           m_menuAction = nullptr;
> +

null pointer is required?

> colorschemechooser.h:66
> +
> +        QString currentColorSchemeName() const;
> +        void    setCurrentColorSchemeName(const QString &name);

const?

> colorschemechooser.h:67
> +        QString currentColorSchemeName() const;
> +        void    setCurrentColorSchemeName(const QString &name);
> +};

Why const & here?

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kdevelop, zhigalin
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160720/72933866/attachment.html>