[Differential] [Commented On] D2220: Implement color scheme selection from these installed in the system using KColorSchemeManager

[zhigalin (Alexander Zhigalin)]

zhigalin added inline comments.

INLINE COMMENTS

> mwolff wrote in colorschemechooser.h:34
> It is a so called forward declaration. We don't actually need to know the ins and outs of how this class looks like, just that it exists somewhere.

Why this instead of

  #include <KActionCollection>

??

> mwolff wrote in colorschemechooser.h:67
> that is following the Qt coding guidelines, which says that you take nearly all (except small) values by const&. Not doing so would incur a copy operation, which may be expensive.

Understood, thanks.

REPOSITORY
  rKDEVPLATFORM KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D2220

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kdevelop, zhigalin
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160720/7fb4011a/attachment.html>