Review Request 126763: Make assistant completion invocation less agressive

[Kevin Funk]

> On Jan. 17, 2016, 2:41 p.m., Alexander Zhigalin wrote:
> > Many people like as-you-type completion.
> > I think we must make it an option instead of switching it off.
> 
> Sven Brauch wrote:
>     I'm not sure how as-you-type completion is related to the changes this patch introduces. This is just about whether to trigger completion because an assistant is available.
> 
> Alexander Zhigalin wrote:
>     > assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space)
>     
>     Doesn't this mean that the completion assistant is shown only when you press the completion hotkey, and not as-you-type?
> 
> Sven Brauch wrote:
>     No, not related. The assistants are the little popups allowing you to rename etc., the code completion is an entirely different thing. The assistants were just moved to the completion popup as a test a while ago, tying invocation of the assistants to invocation of the completion widget. This made the automatic invocation of the completion widget much more frequent than it was before. This patch is trying to roll back some of those changes.

I've reverted the completion changes in master. Does this make this change redundant?


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126763/#review91205
-----------------------------------------------------------


On Jan. 16, 2016, 1:23 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126763/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2016, 1:23 p.m.)
> 
> 
> Review request for KDevelop, Vavelin Kevin and Olivier de Gaalon.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Currently the completion list opens whenever there's assistants available. That is way too agressive (e.g. when just moving the cursor somewhere, the completion list opens). Also you can barely type a line (or even character) without creating a problem, with an associated clang fixit, which invokes completion. This patch attempts to tackle these problems with two changes:
>  - assistant actions now have a flag telling whether they should be shown automatically. This is only set to "on" for the rename assistant currently. Other assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space).
>  - problem-associated assistants are only shown when the revision they are associated with matches the current document revision. This avoids showing assistants while the user is typing (e.g. "add semicolon" when the user has in fact already typed the semicolon).
> 
> 
> Diffs
> -----
> 
>   interfaces/iassistant.h 3f93d52 
>   interfaces/iassistant.cpp b606022 
>   language/assistant/assistantcompletionmodel.h 4a6836a 
>   language/assistant/assistantcompletionmodel.cpp 78bd544 
>   language/assistant/renameassistant.cpp 62f58a0 
>   language/assistant/staticassistantsmanager.cpp 92ca321 
> 
> Diff: https://git.reviewboard.kde.org/r/126763/diff/
> 
> 
> Testing
> -------
> 
> Used it for a while. I find kdevelop significiantly more pleasant to use with those changes.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160127/441605e1/attachment.html>