Review Request 126763: Make assistant completion invocation less agressive

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126763/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 11:32 p.m.)


Status
------

This change has been discarded.


Review request for KDevelop, Vavelin Kevin and Olivier de Gaalon.


Repository: kdevplatform


Description
-------

Currently the completion list opens whenever there's assistants available. That is way too agressive (e.g. when just moving the cursor somewhere, the completion list opens). Also you can barely type a line (or even character) without creating a problem, with an associated clang fixit, which invokes completion. This patch attempts to tackle these problems with two changes:
 - assistant actions now have a flag telling whether they should be shown automatically. This is only set to "on" for the rename assistant currently. Other assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space).
 - problem-associated assistants are only shown when the revision they are associated with matches the current document revision. This avoids showing assistants while the user is typing (e.g. "add semicolon" when the user has in fact already typed the semicolon).


Diffs
-----

  interfaces/iassistant.h 3f93d52 
  interfaces/iassistant.cpp b606022 
  language/assistant/assistantcompletionmodel.h 4a6836a 
  language/assistant/assistantcompletionmodel.cpp 78bd544 
  language/assistant/renameassistant.cpp 62f58a0 
  language/assistant/staticassistantsmanager.cpp 92ca321 

Diff: https://git.reviewboard.kde.org/r/126763/diff/


Testing
-------

Used it for a while. I find kdevelop significiantly more pleasant to use with those changes.


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160127/30d16bbb/attachment-0001.html>