<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126763/">https://git.reviewboard.kde.org/r/126763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2016, 2:41 p.m. UTC, <b>Alexander Zhigalin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many people like as-you-type completion.
I think we must make it an option instead of switching it off.</pre>
</blockquote>
<p>On January 17th, 2016, 4:12 p.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure how as-you-type completion is related to the changes this patch introduces. This is just about whether to trigger completion because an assistant is available.</p></pre>
</blockquote>
<p>On January 17th, 2016, 8:31 p.m. UTC, <b>Alexander Zhigalin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space)</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Doesn't this mean that the completion assistant is shown only when you press the completion hotkey, and not as-you-type?</p></pre>
</blockquote>
<p>On January 18th, 2016, 12:26 a.m. UTC, <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, not related. The assistants are the little popups allowing you to rename etc., the code completion is an entirely different thing. The assistants were just moved to the completion popup as a test a while ago, tying invocation of the assistants to invocation of the completion widget. This made the automatic invocation of the completion widget much more frequent than it was before. This patch is trying to roll back some of those changes.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've reverted the completion changes in master. Does this make this change redundant?</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On January 16th, 2016, 1:23 p.m. UTC, Sven Brauch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop, Vavelin Kevin and Olivier de Gaalon.</div>
<div>By Sven Brauch.</div>
<p style="color: grey;"><i>Updated Jan. 16, 2016, 1:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently the completion list opens whenever there's assistants available. That is way too agressive (e.g. when just moving the cursor somewhere, the completion list opens). Also you can barely type a line (or even character) without creating a problem, with an associated clang fixit, which invokes completion. This patch attempts to tackle these problems with two changes:
- assistant actions now have a flag telling whether they should be shown automatically. This is only set to "on" for the rename assistant currently. Other assistants are only shown when you invoke completion in some other way (e.g. Ctrl+Space).
- problem-associated assistants are only shown when the revision they are associated with matches the current document revision. This avoids showing assistants while the user is typing (e.g. "add semicolon" when the user has in fact already typed the semicolon).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Used it for a while. I find kdevelop significiantly more pleasant to use with those changes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iassistant.h <span style="color: grey">(3f93d52)</span></li>
<li>interfaces/iassistant.cpp <span style="color: grey">(b606022)</span></li>
<li>language/assistant/assistantcompletionmodel.h <span style="color: grey">(4a6836a)</span></li>
<li>language/assistant/assistantcompletionmodel.cpp <span style="color: grey">(78bd544)</span></li>
<li>language/assistant/renameassistant.cpp <span style="color: grey">(62f58a0)</span></li>
<li>language/assistant/staticassistantsmanager.cpp <span style="color: grey">(92ca321)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>