"QAction with KXMLGUIFactory" error/warning message

[René J.V. Bertin]

On Saturday January 02 2016 11:15:46 Kevin Funk wrote:

>This warning means we're using a QAction where a KAction is expected. Just 
....
>Try doing s/QAction/KAction/ in plugins/patchreview/patchreview.cpp and check 

Yeah, I figured that, even without having dug up where the error message is printed (yet) :)

>if it solves your problem (it surely makes the warning go away).

I reckon it will, indeed. So this doesn't evoke a whole list of potential issues that can arise when using a QAction instead of a KAction to you?

It's possible that I my rather liberal replacing of delete foo with foo->deleteLater() already provided a workaround for any such issues, but I think that the main source of the crashing I've been seeing when closing the patch review view was indeed a native event being delivered to an already deleted object. An object that could very well be the commit_or_finish widget.
I had a quick look at the doc comments for KAction; IIUC they're less tricky to clean up than regular QAction instances, correct?

R.