[Differential] [Commented On] D3671: QtHelp fixes

antonanikin (Anton Anikin) noreply at phabricator.kde.org
Thu Dec 15 07:22:21 UTC 2016

antonanikin added inline comments.


> antonanikin wrote in qthelpnetwork.h:60
> > Does it only happen for Qt 5.7.0?
> No, it also happens on ubuntu 16.04 with Qt 5.5.1 - CSS images are not displayed.
> > Now we're always patching contents of .css files here, regardless where the .css file came from. Not a good idea I think.
> Ok, we can move this to QtHelpDocumentation::setUserStyleSheet() method. Or don't fix this issue - now we lost some small images like arrows, not so critical.

> we can move this to QtHelpDocumentation::setUserStyleSheet() method

Original `offline.css` contains 10 (for Qt 5.7.0) wrong lines with relative paths for images. I think it not right to add all such fixes into `setUserStyleSheet()` method. Therefore we have such variants:

1. Keep new CSS-patching as is.
2. Completely remove this code, if it looks as something shady, and push only zero-length content fix.

What are you think about it?

  R32 KDevelop



To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161215/5978d2eb/attachment.html>

More information about the KDevelop-devel mailing list