[Differential] [Commented On] D3671: QtHelp fixes

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS

> antonanikin wrote in qthelpnetwork.h:60
> > we can move this to QtHelpDocumentation::setUserStyleSheet() method
> 
> Original `offline.css` contains 10 (for Qt 5.7.0) wrong lines with relative paths for images. I think it not right to add all such fixes into `setUserStyleSheet()` method. Therefore we have such variants:
> 
> 1. Keep new CSS-patching as is.
> 2. Completely remove this code, if it looks as something shady, and push only zero-length content fix.
> 
> What are you think about it?

If it's just `offline.css`, can we try to a more exact matching on the `fileName()`? So we can be sure we only replace stuff in the right file.

> antonanikin wrote in qthelpnetwork.h:60
> > we can move this to QtHelpDocumentation::setUserStyleSheet() method
> 
> Original `offline.css` contains 10 (for Qt 5.7.0) wrong lines with relative paths for images. I think it not right to add all such fixes into `setUserStyleSheet()` method. Therefore we have such variants:
> 
> 1. Keep new CSS-patching as is.
> 2. Completely remove this code, if it looks as something shady, and push only zero-length content fix.
> 
> What are you think about it?

+1 on pushing the zero-length content fix as -is.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D3671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161216/e6dd2fc2/attachment.html>