[Differential] [Commented On] D3671: QtHelp fixes

antonanikin (Anton Anikin) noreply at phabricator.kde.org
Thu Dec 15 03:39:30 UTC 2016


antonanikin added inline comments.

INLINE COMMENTS

> kfunk wrote in qthelpnetwork.h:60
> Do you have more information about that issue? A bug report maybe? Does it only happen for Qt 5.7.0?
> 
> Now we're always patching contents of .css files here, regardless where the .css file came from. Not a good idea I think.

> Does it only happen for Qt 5.7.0?

No, it also happens on ubuntu 16.04 with Qt 5.5.1 - CSS images are not displayed.

> Now we're always patching contents of .css files here, regardless where the .css file came from. Not a good idea I think.

Ok, we can move this to QtHelpDocumentation::setUserStyleSheet() method. Or don't fix this issue - now we lost some small images like arrows, not so critical.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D3671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161215/af0b0c3d/attachment.html>


More information about the KDevelop-devel mailing list