[Differential] [Requested Changes To] D3671: QtHelp fixes

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added a reviewer: kfunk.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> qthelpnetwork.h:53
>  
> +    // Instantly finish processing if data is empty. Without this code the loadFinished()
> +    // signal will never be emitted by corresponding webView for such cases.

This hunk looks good to me . +1

> qthelpnetwork.h:60
> +
> +    // Fix broken CSS images (tested on Qt 5.7.0)
> +    if (request.url().fileName().endsWith(QStringLiteral(".css"))) {

Do you have more information about that issue? A bug report maybe? Does it only happen for Qt 5.7.0?

Now we're always patching contents of .css files here, regardless where the .css file came from. Not a good idea I think.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D3671

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20161214/7e3d2489/attachment.html>