Review Request 125276: Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake

[Alex Richardson]

> On Sept. 17, 2015, 1:28 a.m., Aleix Pol Gonzalez wrote:
> > cmake/FindClang.cmake, line 33
> > <https://git.reviewboard.kde.org/r/125276/diff/1/?file=404426#file404426line33>
> >
> >     You should be able to specify the requred version as a find_package argument.

The problem is that the LLVMConfig.cmake will only accept exactly matching versions. I.e. the current value of 3.5 will no be accepted by the LLVMConfig.cmake from my 3.8.0svn version.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125276/#review85534
-----------------------------------------------------------


On Sept. 17, 2015, 12:19 a.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125276/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 12:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake
> 
> This has existed at least since 3.5 so we can make use of it
> 
> 
> Diffs
> -----
> 
>   cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
>   cmake/FindLLVM.cmake 4441779f4baac17895914937da245da0d480d755 
> 
> Diff: https://git.reviewboard.kde.org/r/125276/diff/
> 
> 
> Testing
> -------
> 
> Works for me with 3.7
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150917/545e4d12/attachment.html>