Review Request 125276: Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake

Alex Richardson arichardson.kde at gmail.com
Thu Sep 17 12:04:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125276/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 1:04 p.m.)


Review request for KDevelop.


Changes
-------

Add a comment why we can't use the version argument to find_package()


Repository: kdev-clang


Description
-------

Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake

This has existed at least since 3.5 so we can make use of it


Diffs (updated)
-----

  cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
  cmake/FindLLVM.cmake 4441779f4baac17895914937da245da0d480d755 

Diff: https://git.reviewboard.kde.org/r/125276/diff/


Testing
-------

Works for me with 3.7


Thanks,

Alex Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150917/9237a508/attachment.html>


More information about the KDevelop-devel mailing list