Review Request 125276: Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125276/#review85534
-----------------------------------------------------------



cmake/FindClang.cmake (line 33)
<https://git.reviewboard.kde.org/r/125276/#comment59113>

    You should be able to specify the requred version as a find_package argument.


- Aleix Pol Gonzalez


On Sept. 17, 2015, 1:19 a.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125276/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 1:19 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Use the upstream LLVMConfig.cmake instead of FindLLVM.cmake
> 
> This has existed at least since 3.5 so we can make use of it
> 
> 
> Diffs
> -----
> 
>   cmake/FindClang.cmake 6c9bd6ef0242319122dcc7e6fd6cea8d9f0cbfbb 
>   cmake/FindLLVM.cmake 4441779f4baac17895914937da245da0d480d755 
> 
> Diff: https://git.reviewboard.kde.org/r/125276/diff/
> 
> 
> Testing
> -------
> 
> Works for me with 3.7
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150917/2c142bf0/attachment.html>