Review Request 125853: Fix Segfault on unsuccessful upload.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125853/#review87647
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Oct. 28, 2015, 9:58 p.m., Jakub Caban wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125853/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 9:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-upload
> 
> 
> Description
> -------
> 
> Previous method didn't work as expected so I've changed it to solution derived from Porting Notes (replacing casting KJob to KIO::Job with calling job->uiDelegate() directly).
> 
> 
> Diffs
> -----
> 
>   uploadjob.cpp 9fb1754 
> 
> Diff: https://git.reviewboard.kde.org/r/125853/diff/
> 
> 
> Testing
> -------
> 
> Tested on fake profile with wrong upload path. Error box appeared and upload was stopped. Also log note aappeared as it should.
> 
> also tested uploading ocrrectly set projects and everything works as before.
> 
> 
> Thanks,
> 
> Jakub Caban
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151029/59b2621a/attachment.html>