Review Request 125853: Fix Segfault on unsuccessful upload.

[Jakub Caban]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125853/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 11:23 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Changes
-------

Submitted with commit e9bffed5f21c55120a4ce82cf83eaea44e051619 by Jakub Caban to branch master.


Repository: kdev-upload


Description
-------

Previous method didn't work as expected so I've changed it to solution derived from Porting Notes (replacing casting KJob to KIO::Job with calling job->uiDelegate() directly).


Diffs
-----

  uploadjob.cpp 9fb1754 

Diff: https://git.reviewboard.kde.org/r/125853/diff/


Testing
-------

Tested on fake profile with wrong upload path. Error box appeared and upload was stopped. Also log note aappeared as it should.

also tested uploading ocrrectly set projects and everything works as before.


Thanks,

Jakub Caban

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151029/5b137ff5/attachment-0001.html>