Review Request 125853: Fix Segfault on unsuccessful upload.

Jakub Caban kuba at whyblack.pl
Wed Oct 28 21:58:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125853/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdev-upload


Description
-------

Previous method didn't work as expected so I've changed it to solution derived from Porting Notes (replacing casting KJob to KIO::Job with calling job->uiDelegate() directly).


Diffs
-----

  uploadjob.cpp 9fb1754 

Diff: https://git.reviewboard.kde.org/r/125853/diff/


Testing
-------

Tested on fake profile with wrong upload path. Error box appeared and upload was stopped. Also log note aappeared as it should.

also tested uploading ocrrectly set projects and everything works as before.


Thanks,

Jakub Caban

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151028/4f28023c/attachment.html>


More information about the KDevelop-devel mailing list