Review Request 126044: Add mising dependency on kdelibs4support

Kevin Funk kfunk at kde.org
Wed Nov 25 09:49:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126044/#review88787
-----------------------------------------------------------


Ah. Okay, you've been referring to the 4.90.90 tag.

We fixed this in the 5.0 branch already:

kdev-python is KF5-based by now, Sven pushed a few fixes after the 4.90.90 tag. See here:

```
* 897ccff - remove KLocale #include in two files (4 weeks ago) <Sven Brauch>
...
* fa3948e - remove #include requiring an (unused) KDE4 header (4 weeks ago) <Sven Brauch>
...
* b447fac - use generate_export_header for debugger plugin as well (4 weeks ago) <Sven Brauch>
...
* 4a3e45f - (tag: v4.90.90) SVN_SILENT made messages (.desktop file) (5 weeks ago) <l10n daemon script>
```

- Kevin Funk


On Nov. 12, 2015, 2:10 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126044/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 2:10 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> I'm unable to build kdev-python without this patch. Kdelibs4Support is required because of kdeversion.h and kdemacro.h headers.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1146905 
>   debugger/CMakeLists.txt 20ead1a 
>   duchain/CMakeLists.txt 2da1253 
> 
> Diff: https://git.reviewboard.kde.org/r/126044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151125/d2edbf0f/attachment.html>


More information about the KDevelop-devel mailing list