Review Request 126044: Add mising dependency on kdelibs4support

[Jan Grulich]

> On Lis. 24, 2015, 8:18 odp., Kevin Funk wrote:
> > Where do you see uses of kdeversion.h and kdemacro.h? I don't.
> > 
> > Compiles fine for me without any kdelibs headers installed.

It doesn't build in our Fedora build system without that patch.

Here is one of the errors:
CMakeFiles/kdevpdb.dir/pdbdebuggerplugin.cpp.o -c /builddir/build/BUILD/kdev-python-4.90.90/debugger/pdbdebuggerplugin.cpp
In file included from /builddir/build/BUILD/kdev-python-4.90.90/debugger/pdbdebuggerplugin.h:24:0,
                 from /builddir/build/BUILD/kdev-python-4.90.90/debugger/pdbdebuggerplugin.cpp:24:
/builddir/build/BUILD/kdev-python-4.90.90/debugger/pythondebugexport.h:25:23: fatal error: kdemacros.h: No such file or directory
compilation terminated.
debugger/CMakeFiles/kdevpdb.dir/build.make:234: recipe for target 'debugger/CMakeFiles/kdevpdb.dir/pdbdebuggerplugin.cpp.o' failed
make[2]: *** [debugger/CMakeFiles/kdevpdb.dir/pdbdebuggerplugin.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126044/#review88771
-----------------------------------------------------------


On Lis. 12, 2015, 2:10 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126044/
> -----------------------------------------------------------
> 
> (Updated Lis. 12, 2015, 2:10 odp.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> I'm unable to build kdev-python without this patch. Kdelibs4Support is required because of kdeversion.h and kdemacro.h headers.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1146905 
>   debugger/CMakeLists.txt 20ead1a 
>   duchain/CMakeLists.txt 2da1253 
> 
> Diff: https://git.reviewboard.kde.org/r/126044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151125/8ca5ea2b/attachment.html>