<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126044/">https://git.reviewboard.kde.org/r/126044/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah. Okay, you've been referring to the 4.90.90 tag.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We fixed this in the 5.0 branch already:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdev-python is KF5-based by now, Sven pushed a few fixes after the 4.90.90 tag. See here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">* 897ccff - remove KLocale #include in two files (4 weeks ago) <Sven Brauch>
...
* fa3948e - remove #include requiring an (unused) KDE4 header (4 weeks ago) <Sven Brauch>
...
* b447fac - use generate_export_header for debugger plugin as well (4 weeks ago) <Sven Brauch>
...
* 4a3e45f - (tag: v4.90.90) SVN_SILENT made messages (.desktop file) (5 weeks ago) <l10n daemon script>
</pre></div>
</p></pre>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 12th, 2015, 2:10 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop and Sven Brauch.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2015, 2:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm unable to build kdev-python without this patch. Kdelibs4Support is required because of kdeversion.h and kdemacro.h headers.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1146905)</span></li>
<li>debugger/CMakeLists.txt <span style="color: grey">(20ead1a)</span></li>
<li>duchain/CMakeLists.txt <span style="color: grey">(2da1253)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>