Review Request 126062: Port "Attach to process" to KF5

[Milian Wolff]

> On Nov. 14, 2015, 3:59 p.m., Milian Wolff wrote:
> > lgtm, I'll try it out right-away. Do you have commit rights?
> > 
> > Thanks!
> 
> Milian Wolff wrote:
>     Tested it, works as advertisted! Nice work. Maybe increase the default size of the dialog slightly, but otherwise I'm all for integrating this change. If you don't have commit rights, I can do that for you.
> 
> Iain Nicol wrote:
>     Thanks.  I don't have commit rights, because this is my first KDE patch :-).
>     
>     I'll push a revision to here addressing your comments.
>     
>     After I click OK on the button, it works for me... except I see a phantom (slightly transparent) panel on the bottom of the screen.  As if the Output window or another panel had crashed.  I can't see how it's related to this patch.  But hopefully that doesn't happen for you?

I don't see any issue like that. But we probably do have some bugs in the debug area. Unrelated to this patch though.

One thing I just reliazed though: We don't filter the current KDevelop process. That would allow you to attach to yourself, thereby deadlocking the application... Is it possible to apply a filter?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126062/#review88352
-----------------------------------------------------------


On Nov. 14, 2015, 4:37 p.m., Iain Nicol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126062/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 4:37 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This consists of tweaking the build, plus porting from KDialog to
> QDialog.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/CMakeLists.txt 57eab84988d9f7d954545bf95a7615e002dd744a 
>   debuggers/gdb/processselection.h e6046550b6df95c5ebc973ebef758a39c1f83f16 
>   debuggers/gdb/processselection.cpp 8bee72e9d6c4ef94cd7df7084d13133b43168fd2 
> 
> Diff: https://git.reviewboard.kde.org/r/126062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Iain Nicol
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151114/d96612dc/attachment.html>