Review Request 126062: Port "Attach to process" to KF5

[Iain Nicol]

> On Nov. 14, 2015, 3:59 p.m., Milian Wolff wrote:
> > lgtm, I'll try it out right-away. Do you have commit rights?
> > 
> > Thanks!
> 
> Milian Wolff wrote:
>     Tested it, works as advertisted! Nice work. Maybe increase the default size of the dialog slightly, but otherwise I'm all for integrating this change. If you don't have commit rights, I can do that for you.

Thanks.  I don't have commit rights, because this is my first KDE patch :-).

I'll push a revision to here addressing your comments.

After I click OK on the button, it works for me... except I see a phantom (slightly transparent) panel on the bottom of the screen.  As if the Output window or another panel had crashed.  I can't see how it's related to this patch.  But hopefully that doesn't happen for you?


> On Nov. 14, 2015, 3:59 p.m., Milian Wolff wrote:
> > debuggers/gdb/CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/126062/diff/1/?file=416854#file416854line18>
> >
> >     this could now also be run on mac, no? it's an optional find after all. but I'm also OK with leaving it as-is for now

Yeah, I wasn't sure about this.  I'll remove the ifdef.


- Iain


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126062/#review88352
-----------------------------------------------------------


On Nov. 14, 2015, 12:31 p.m., Iain Nicol wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126062/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 12:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This consists of tweaking the build, plus porting from KDialog to
> QDialog.
> 
> 
> Diffs
> -----
> 
>   debuggers/gdb/processselection.h e6046550b6df95c5ebc973ebef758a39c1f83f16 
>   debuggers/gdb/processselection.cpp 8bee72e9d6c4ef94cd7df7084d13133b43168fd2 
>   debuggers/gdb/CMakeLists.txt 57eab84988d9f7d954545bf95a7615e002dd744a 
> 
> Diff: https://git.reviewboard.kde.org/r/126062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Iain Nicol
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151114/61c3a383/attachment-0001.html>