<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126062/">https://git.reviewboard.kde.org/r/126062/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 14th, 2015, 3:59 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">lgtm, I'll try it out right-away. Do you have commit rights?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks!</p></pre>
</blockquote>
<p>On November 14th, 2015, 4:06 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested it, works as advertisted! Nice work. Maybe increase the default size of the dialog slightly, but otherwise I'm all for integrating this change. If you don't have commit rights, I can do that for you.</p></pre>
</blockquote>
<p>On November 14th, 2015, 4:15 p.m. UTC, <b>Iain Nicol</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks. I don't have commit rights, because this is my first KDE patch :-).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll push a revision to here addressing your comments.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">After I click OK on the button, it works for me... except I see a phantom (slightly transparent) panel on the bottom of the screen. As if the Output window or another panel had crashed. I can't see how it's related to this patch. But hopefully that doesn't happen for you?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't see any issue like that. But we probably do have some bugs in the debug area. Unrelated to this patch though.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One thing I just reliazed though: We don't filter the current KDevelop process. That would allow you to attach to yourself, thereby deadlocking the application... Is it possible to apply a filter?</p></pre>
<br />
<p>- Milian</p>
<br />
<p>On November 14th, 2015, 4:37 p.m. UTC, Iain Nicol wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Iain Nicol.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2015, 4:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This consists of tweaking the build, plus porting from KDialog to
QDialog.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debuggers/gdb/CMakeLists.txt <span style="color: grey">(57eab84988d9f7d954545bf95a7615e002dd744a)</span></li>
<li>debuggers/gdb/processselection.h <span style="color: grey">(e6046550b6df95c5ebc973ebef758a39c1f83f16)</span></li>
<li>debuggers/gdb/processselection.cpp <span style="color: grey">(8bee72e9d6c4ef94cd7df7084d13133b43168fd2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126062/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>