Review Request 123191: Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )

[Laszlo Kis-Adam]

> On March 31, 2015, 8:03 a.m., Kevin Funk wrote:
> > We need to make it clear where those two backtraces come from, otherwise it might be confusing.
> > 
> > Maybe show the "Invalid read at ...", and "Address 0x0 stack'd by ..." messages in the listing, too?

OK, I'll do it.


> On March 31, 2015, 8:03 a.m., Kevin Funk wrote:
> > models/memcheckmodel.cpp, line 195
> > <https://git.reviewboard.kde.org/r/123191/diff/1/?file=359593#file359593line195>
> >
> >     Why not just `frames << s->getFrames()`?

I find that a lot less readable. In fact operator overloading in general makes code a lot less readable. For someone who works with the code it's obvious, but for someone new it's confusing.
If you want me to ofc I can change it anyways.


> On March 31, 2015, 8:03 a.m., Kevin Funk wrote:
> > models/memcheckmodel.cpp, line 193
> > <https://git.reviewboard.kde.org/r/123191/diff/1/?file=359593#file359593line193>
> >
> >     Style: This and below: 
> >     - No single char variable names please
> >     - Space after keyword
> >     - No space inside `()`

- The code already uses single char variables, but OK, I'll change mine.
- That no-space directive makes code a lot less readable, but so be it.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123191/#review78264
-----------------------------------------------------------


On March 31, 2015, 2:52 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123191/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 2:52 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )
> 
> 
> Diffs
> -----
> 
>   models/memcheckmodel.cpp ad42605 
> 
> Diff: https://git.reviewboard.kde.org/r/123191/diff/
> 
> 
> Testing
> -------
> 
> * built
> * installed
> * it works as intended.
> 
> Take a look at the difference:
> Before:
> http://www.picbutler.de/bild/321320/20150331000002312k3ncw.jpg
> 
> After:
> http://www.picbutler.de/bild/321321/201503310000023132yrhe.jpg
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150331/956820c7/attachment.html>