Review Request 123191: Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123191/#review78264
-----------------------------------------------------------


We need to make it clear where those two backtraces come from, otherwise it might be confusing.

Maybe show the "Invalid read at ...", and "Address 0x0 stack'd by ..." messages in the listing, too?


models/memcheckmodel.cpp (line 193)
<https://git.reviewboard.kde.org/r/123191/#comment53603>

    Style: This and below: 
    - No single char variable names please
    - Space after keyword
    - No space inside `()`



models/memcheckmodel.cpp (line 195)
<https://git.reviewboard.kde.org/r/123191/#comment53604>

    Why not just `frames << s->getFrames()`?


- Kevin Funk


On March 31, 2015, 12:52 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123191/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 12:52 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Show more of the backtrace of the found problems. Also show the auxiliary backtrace ( source of the problem )
> 
> 
> Diffs
> -----
> 
>   models/memcheckmodel.cpp ad42605 
> 
> Diff: https://git.reviewboard.kde.org/r/123191/diff/
> 
> 
> Testing
> -------
> 
> * built
> * installed
> * it works as intended.
> 
> Take a look at the difference:
> Before:
> http://www.picbutler.de/bild/321320/20150331000002312k3ncw.jpg
> 
> After:
> http://www.picbutler.de/bild/321321/201503310000023132yrhe.jpg
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150331/020df780/attachment-0001.html>