Review Request 123959: Be Smarter About Handling Current Work Dir

[David Narváez]

> On May 31, 2015, 10:08 p.m., Aleix Pol Gonzalez wrote:
> > shell/projectsourcepage.cpp, line 249
> > <https://git.reviewboard.kde.org/r/123959/diff/1/?file=378419#file378419line249>
> >
> >     If it's a Url, you can't pass it to QFileInfo...

Oh, you mean if the workingDir is something like fish://some/file? I had not thought of that, in which case the current code makes a lot of sense. I'll discard this review then, since the case I am covering is easy to fix manually.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123959/#review81022
-----------------------------------------------------------


On May 31, 2015, 4:23 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123959/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 4:23 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The corner case this tries to handle is when I set my default folder to
> /path/to/folder/withou/trailing/slash because in that case the code we
> had will chop 'slash' from the path and my code will end up inside the
> parent folder of the one I chose as default.
> 
> The case in which this analysis will fail is if you, e.g., choose to
> fetch a KDE project, you click on a project you already have (now the
> work dir exists and is a dir) and then you click some other project.
> Your new project will end up inside the project you chose first. But I
> think that is a better compromise than messing up a default folder
> without a trailing slash.
> 
> 
> Diffs
> -----
> 
>   shell/projectsourcepage.cpp 62ffbb6deefde83ca1f43e4a72f2b42cebd1ceb6 
> 
> Diff: https://git.reviewboard.kde.org/r/123959/diff/
> 
> 
> Testing
> -------
> 
> 1. Set your default project folder to a path to an existing folder, without a trailing slash (e.g., /home/user/Projects)
> 2. Select the KDE Provider
> 3. Choose a project
> 4. Check the project dir
> 
> Before this patch, your project dir will be /home/user/your_project. After this patch, your project dir will be /home/user/Projects/your_project.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150601/ebd93d99/attachment.html>