Review Request 124506: Add protected members from base classes into completions in derived classes

[Sergey Kalinichev]

> On July 28, 2015, 3:54 p.m., Alex Richardson wrote:
> > tests/test_codecompletion.cpp, line 723
> > <https://git.reviewboard.kde.org/r/124506/diff/1/?file=388340#file388340line723>
> >
> >     Maybe this is related to `clang::DeclContext::getLexicalDeclContext()` vs 
> >     `clang::DeclContext::getDeclContext()`
> >     
> >     (http://clang.llvm.org/docs/InternalsManual.html#lexical-and-semantic-contexts)
> >     
> >     Not sure if there is anything in the C API that reflects this since I've only used the C++ classes so far.

Yes. This should be fixed by https://git.reviewboard.kde.org/r/124513/


> On July 28, 2015, 3:54 p.m., Alex Richardson wrote:
> > codecompletion/context.cpp, line 740
> > <https://git.reviewboard.kde.org/r/124506/diff/1/?file=388339#file388339line740>
> >
> >     This sounds like a bug to me and should be reported to the clang developers

Yes, it is. Feel free to report it! Also you could look through the kdev-clang code, and report all other LibClang bugs. (there are quite a few of them).


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124506/#review83089
-----------------------------------------------------------


On July 28, 2015, 1:39 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124506/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 1:39 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Clang considers all protected members from base classes as not
> accessible from derived classes
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 61c36b8 
>   tests/test_codecompletion.cpp c54206d 
> 
> Diff: https://git.reviewboard.kde.org/r/124506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150728/ae885227/attachment.html>