Review Request 124506: Add protected members from base classes into completions in derived classes

Alex Richardson arichardson.kde at gmail.com
Tue Jul 28 12:54:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124506/#review83089
-----------------------------------------------------------



codecompletion/context.cpp (line 740)
<https://git.reviewboard.kde.org/r/124506/#comment57369>

    This sounds like a bug to me and should be reported to the clang developers



tests/test_codecompletion.cpp (line 723)
<https://git.reviewboard.kde.org/r/124506/#comment57368>

    Maybe this is related to `clang::DeclContext::getLexicalDeclContext()` vs 
    `clang::DeclContext::getDeclContext()`
    
    (http://clang.llvm.org/docs/InternalsManual.html#lexical-and-semantic-contexts)
    
    Not sure if there is anything in the C API that reflects this since I've only used the C++ classes so far.


- Alex Richardson


On July 28, 2015, 11:39 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124506/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 11:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Clang considers all protected members from base classes as not
> accessible from derived classes
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 61c36b8 
>   tests/test_codecompletion.cpp c54206d 
> 
> Diff: https://git.reviewboard.kde.org/r/124506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150728/dbabe536/attachment.html>


More information about the KDevelop-devel mailing list