Review Request 124506: Add protected members from base classes into completions in derived classes

Milian Wolff mail at milianw.de
Tue Jul 28 17:17:13 UTC 2015



> On July 28, 2015, 12:54 p.m., Alex Richardson wrote:
> > codecompletion/context.cpp, line 740
> > <https://git.reviewboard.kde.org/r/124506/diff/1/?file=388339#file388339line740>
> >
> >     This sounds like a bug to me and should be reported to the clang developers
> 
> Sergey Kalinichev wrote:
>     Yes, it is. Feel free to report it! Also you could look through the kdev-clang code, and report all other LibClang bugs. (there are quite a few of them).

but you have the knowledge, no? couldn't you create a small example c file using clang-c and an input file to show the behavior. see e.g. how I reported https://llvm.org/bugs/show_bug.cgi?id=24268 - this is _very_ valuable contribution, please do this as part of your GSOC.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124506/#review83089
-----------------------------------------------------------


On July 28, 2015, 10:39 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124506/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 10:39 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Clang considers all protected members from base classes as not
> accessible from derived classes
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.cpp 61c36b8 
>   tests/test_codecompletion.cpp c54206d 
> 
> Diff: https://git.reviewboard.kde.org/r/124506/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150728/92b603d1/attachment.html>


More information about the KDevelop-devel mailing list