Review Request 124412: Removal of obsolete kdelibs4support headers

Raymond Wooninck tittiatcoke at gmail.com
Tue Jul 21 14:41:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124412/
-----------------------------------------------------------

(Updated July 21, 2015, 2:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Milian Wolff.


Changes
-------

Submitted with commit ebe3026c5e09406105933911c1125190684a6283 by Raymond Wooninck to branch master.


Repository: kdev-php


Description
-------

This patch makes kdev-php build again without kdelibs4support. It seems that the porting was already done, but some headers were not yet removed. Only porting required was in duchain/tests/duchain.cpp with regards to the KStandardDirs


Diffs
-----

  completion/context.h eac2348 
  completion/model.cpp 5df3aaf 
  duchain/navigation/declarationnavigationcontext.cpp 79503fa 
  duchain/tests/duchain.cpp 4090b34 
  kdevphpversion.h.cmake 5412689 
  phplanguagesupport.cpp 7862916 
  phpparsejob.h 0db2279 
  phpparsejob.cpp 76504df 

Diff: https://git.reviewboard.kde.org/r/124412/diff/


Testing
-------

Patch applies correctly and package builds


Thanks,

Raymond Wooninck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150721/3486d47b/attachment.html>


More information about the KDevelop-devel mailing list