Review Request 124412: Removal of obsolete kdelibs4support headers

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124412/#review82766
-----------------------------------------------------------

Ship it!


assuming the test still work, I'm all for it!

thanks

- Milian Wolff


On July 21, 2015, 12:01 p.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124412/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 12:01 p.m.)
> 
> 
> Review request for KDevelop and Milian Wolff.
> 
> 
> Repository: kdev-php
> 
> 
> Description
> -------
> 
> This patch makes kdev-php build again without kdelibs4support. It seems that the porting was already done, but some headers were not yet removed. Only porting required was in duchain/tests/duchain.cpp with regards to the KStandardDirs
> 
> 
> Diffs
> -----
> 
>   completion/context.h eac2348 
>   completion/model.cpp 5df3aaf 
>   duchain/navigation/declarationnavigationcontext.cpp 79503fa 
>   duchain/tests/duchain.cpp 4090b34 
>   kdevphpversion.h.cmake 5412689 
>   phplanguagesupport.cpp 7862916 
>   phpparsejob.h 0db2279 
>   phpparsejob.cpp 76504df 
> 
> Diff: https://git.reviewboard.kde.org/r/124412/diff/
> 
> 
> Testing
> -------
> 
> Patch applies correctly and package builds
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150721/9e73dfbe/attachment.html>