Review Request 122125: read plugin file only once

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122125/#review74251
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Jan. 18, 2015, 4:08 p.m., Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122125/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2015, 4:08 p.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> KPluginLoader::factory() is calling instance() which calls load().
> The plugin file will be red two times.
> This is not necessary.
> Save some little CPU time by reading only once.
> 
> 
> Diffs
> -----
> 
>   src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 
> 
> Diff: https://git.reviewboard.kde.org/r/122125/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy Maurel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150118/027123fa/attachment.html>