Review Request 122125: read plugin file only once

Guy Maurel guy-kde at maurel.de
Sun Jan 18 16:08:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122125/
-----------------------------------------------------------

(Updated Jan. 18, 2015, 5:08 p.m.)


Review request for KDevelop and Kevin Funk.


Changes
-------

of course not. It was only for me.
Thanks


Repository: kcoreaddons


Description
-------

KPluginLoader::factory() is calling instance() which calls load().
The plugin file will be red two times.
This is not necessary.
Save some little CPU time by reading only once.


Diffs (updated)
-----

  src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 

Diff: https://git.reviewboard.kde.org/r/122125/diff/


Testing
-------


Thanks,

Guy Maurel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150118/9a4aa3c8/attachment.html>


More information about the KDevelop-devel mailing list