Review Request 122125: read plugin file only once

Guy Maurel guy-kde at maurel.de
Mon Jan 19 17:35:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122125/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 5:35 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Kevin Funk.


Repository: kcoreaddons


Description
-------

KPluginLoader::factory() is calling instance() which calls load().
The plugin file will be red two times.
This is not necessary.
Save some little CPU time by reading only once.


Diffs
-----

  src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 

Diff: https://git.reviewboard.kde.org/r/122125/diff/


Testing
-------


Thanks,

Guy Maurel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150119/1625ff90/attachment.html>


More information about the KDevelop-devel mailing list