Review Request 126354: Drop kdelibs4support

[Laurent Navet]

> On déc. 15, 2015, 11:20 matin, Kevin Funk wrote:
> > parsers/callgrindparser.cpp, line 101
> > <https://git.reviewboard.kde.org/r/126354/diff/1/?file=422787#file422787line101>
> >
> >     Careful, the replacement for `toAscii` is `toLatin1`.
> >     
> >     Won't matter here, but still...

reading here http://doc.qt.io/qt-5/qchar-obsolete.html#toAscii
it seems to me that it was better to use unicode but I may have misundertood...


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126354/#review89532
-----------------------------------------------------------


On déc. 15, 2015, 11:11 matin, Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126354/
> -----------------------------------------------------------
> 
> (Updated déc. 15, 2015, 11:11 matin)
> 
> 
> Review request for KDevelop Valgrind Plugin, KDevelop, Kevin Funk, and Milian Wolff.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Adapt CMakelists.txt + minor fix to be able to compile upon Qt5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9194ef9 
>   parsers/callgrindparser.cpp cb41bd3 
> 
> Diff: https://git.reviewboard.kde.org/r/126354/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151215/7bdedc43/attachment.html>