Review Request 126354: Drop kdelibs4support
Kevin Funk
kfunk at kde.org
Tue Dec 15 10:20:41 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126354/#review89532
-----------------------------------------------------------
parsers/callgrindparser.cpp (line 101)
<https://git.reviewboard.kde.org/r/126354/#comment61268>
Careful, the replacement for `toAscii` is `toLatin1`.
Won't matter here, but still...
- Kevin Funk
On Dec. 15, 2015, 10:11 a.m., Laurent Navet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126354/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 10:11 a.m.)
>
>
> Review request for KDevelop Valgrind Plugin, KDevelop, Kevin Funk, and Milian Wolff.
>
>
> Repository: kdev-valgrind
>
>
> Description
> -------
>
> Adapt CMakelists.txt + minor fix to be able to compile upon Qt5
>
>
> Diffs
> -----
>
> CMakeLists.txt 9194ef9
> parsers/callgrindparser.cpp cb41bd3
>
> Diff: https://git.reviewboard.kde.org/r/126354/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Laurent Navet
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151215/7ae9107a/attachment.html>
More information about the KDevelop-devel
mailing list