Review Request 126354: Drop kdelibs4support

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126354/#review89541
-----------------------------------------------------------



parsers/callgrindparser.cpp (line 101)
<https://git.reviewboard.kde.org/r/126354/#comment61275>

    Note: unicode() returns a ushort which is 16 bit, char is only 8 bit.
    
    Now when unicode() returns a number not fitting into the char-range (non-latin1 char) => integral conversion => char may end up containing an invalid char (or a valid one, but not the one you expect).
    
    So it's safer to use `toLatin1()` here, which just returns a 0-char in such cases.


- Kevin Funk


On Dec. 15, 2015, 10:11 a.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126354/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 10:11 a.m.)
> 
> 
> Review request for KDevelop Valgrind Plugin, KDevelop, Kevin Funk, and Milian Wolff.
> 
> 
> Repository: kdev-valgrind
> 
> 
> Description
> -------
> 
> Adapt CMakelists.txt + minor fix to be able to compile upon Qt5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9194ef9 
>   parsers/callgrindparser.cpp cb41bd3 
> 
> Diff: https://git.reviewboard.kde.org/r/126354/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20151215/88271bd4/attachment.html>