Review Request 124745: Always attach AST to the active document

[Sergey Kalinichev]

> On Aug. 19, 2015, 12:30 p.m., Milian Wolff wrote:
> > clangparsejob.cpp, line 162
> > <https://git.reviewboard.kde.org/r/124745/diff/1/?file=394821#file394821line162>
> >
> >     I'd return the AST smartptr here and rename the function - it's not about finding a context for a file anymore, it's about finding the context which has an AST

Actually this function finds a context (with or without an AST), and findParseSession finds the AST.

Anyway now I've changed the code, hope it'll clarify the things a bit.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124745/#review84034
-----------------------------------------------------------


On Aug. 20, 2015, 11:32 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124745/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 11:32 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h ba2d5ac 
>   clangparsejob.cpp a80433e 
>   clangsupport.h a047382 
>   clangsupport.cpp 22b6c96 
>   codecompletion/model.cpp 57902d3 
>   tests/test_duchain.h 694f5a2 
>   tests/test_duchain.cpp 796e3c6 
> 
> Diff: https://git.reviewboard.kde.org/r/124745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150820/0e026492/attachment-0001.html>