Review Request 124745: Always attach AST to the active document

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124745/#review84034
-----------------------------------------------------------



clangparsejob.cpp (line 158)
<https://git.reviewboard.kde.org/r/124745/#comment58205>

    I'd return the AST smartptr here and rename the function - it's not about finding a context for a file anymore, it's about finding the context which has an AST



clangparsejob.cpp (line 177)
<https://git.reviewboard.kde.org/r/124745/#comment58206>

    once you return the smartptr, it should be safe to remove this again



clangparsejob.cpp (line 227)
<https://git.reviewboard.kde.org/r/124745/#comment58207>

    just the active document? any document that's open, no? and then just set a flag/bool that this should get the ast attached, i.e. isn't AttachASTWithoutUpdating sufficient then? imo this block should be removed



clangparsejob.cpp (line 269)
<https://git.reviewboard.kde.org/r/124745/#comment58209>

    isn't a `return;` missing here?



tests/test_duchain.cpp (line 714)
<https://git.reviewboard.kde.org/r/124745/#comment58210>

    push this into a new test function please


- Milian Wolff


On Aug. 15, 2015, 4:24 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124745/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2015, 4:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.h ba2d5ac 
>   clangparsejob.cpp a80433e 
>   clangsupport.h a047382 
>   clangsupport.cpp 22b6c96 
>   tests/test_duchain.cpp 796e3c6 
> 
> Diff: https://git.reviewboard.kde.org/r/124745/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150819/11129697/attachment.html>