<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124745/">https://git.reviewboard.kde.org/r/124745/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 19th, 2015, 12:30 p.m. MSK, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124745/diff/1/?file=394821#file394821line162" style="color: black; font-weight: bold; text-decoration: underline;">clangparsejob.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">162</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">ParseSessionData</span><span class="o">::</span><span class="n">Ptr</span> <span class="n">findParseSession</span><span class="p">(</span><span class="k">const</span> <span class="n">IndexedString</span> <span class="o">&</span><span class="n">file</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">TopDUContext</span><span class="o">*</span> <span class="n">findContextForFile</span><span class="p">(</span><span class="k">const</span> <span class="n">IndexedString</span><span class="o">&</span> <span class="n">currentFile</span><span class="p">,</span> <span class="k">const</span> <span class="n">IndexedString</span><span class="o">&</span> <span class="n">tuFile</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd return the AST smartptr here and rename the function - it's not about finding a context for a file anymore, it's about finding the context which has an AST</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Actually this function finds a context (with or without an AST), and findParseSession finds the AST.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyway now I've changed the code, hope it'll clarify the things a bit.</p></pre>
<br />
<p>- Sergey</p>
<br />
<p>On August 20th, 2015, 11:32 a.m. MSK, Sergey Kalinichev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sergey Kalinichev.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 11:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-clang
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should fix the issue when we had no code completion after restoring context from disk, if the active document wasn't modified beforehand.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>clangparsejob.h <span style="color: grey">(ba2d5ac)</span></li>
<li>clangparsejob.cpp <span style="color: grey">(a80433e)</span></li>
<li>clangsupport.h <span style="color: grey">(a047382)</span></li>
<li>clangsupport.cpp <span style="color: grey">(22b6c96)</span></li>
<li>codecompletion/model.cpp <span style="color: grey">(57902d3)</span></li>
<li>tests/test_duchain.h <span style="color: grey">(694f5a2)</span></li>
<li>tests/test_duchain.cpp <span style="color: grey">(796e3c6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124745/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>