Review Request 124598: Extract variable refactoring

[Maciej Poleski]

> On Sie 10, 2015, 9:21 po południu, Milian Wolff wrote:
> > refactoring/error.cpp, line 58
> > <https://git.reviewboard.kde.org/r/124598/diff/3/?file=389674#file389674line58>
> >
> >     Q_ASSERT_X, and use a better message. what does it mean? that this code needs to be extended, or that something else went wrong?

It is dead code (as long as implementation is up-to-date with enumeration)


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124598/#review83669
-----------------------------------------------------------


On Sie 3, 2015, 8:33 po południu, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124598/
> -----------------------------------------------------------
> 
> (Updated Sie 3, 2015, 8:33 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract variable refactoring
> 
> Select some expression, right click, [Extract variable], type name of new variable to create, enjoy
> 
> This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/error.h PRE-CREATION 
>   refactoring/error.cpp PRE-CREATION 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_extractvariable.h PRE-CREATION 
>   tests/test_extractvariable.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124598/diff/
> 
> 
> Testing
> -------
> 
> Tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150810/11271a78/attachment-0001.html>