Review Request 124598: Extract variable refactoring

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124598/#review83669
-----------------------------------------------------------



refactoring/error.cpp (line 34)
<https://git.reviewboard.kde.org/r/124598/#comment57905>

    = 0



refactoring/error.cpp (line 35)
<https://git.reviewboard.kde.org/r/124598/#comment57904>

    = nullptr



refactoring/error.cpp (line 36)
<https://git.reviewboard.kde.org/r/124598/#comment57903>

    join next line



refactoring/error.cpp (line 40)
<https://git.reviewboard.kde.org/r/124598/#comment57906>

    spaces around operators



refactoring/error.cpp (line 41)
<https://git.reviewboard.kde.org/r/124598/#comment57907>

    please no inline classes, push that out into an anonymous namespace



refactoring/error.cpp (line 58)
<https://git.reviewboard.kde.org/r/124598/#comment57908>

    Q_ASSERT_X, and use a better message. what does it mean? that this code needs to be extended, or that something else went wrong?



refactoring/error.cpp (line 60)
<https://git.reviewboard.kde.org/r/124598/#comment57909>

    space after ,



refactoring/extractvariablerefactoring.h (line 37)
<https://git.reviewboard.kde.org/r/124598/#comment57910>

    remove 2nd empty line


- Milian Wolff


On Aug. 3, 2015, 6:33 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124598/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 6:33 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract variable refactoring
> 
> Select some expression, right click, [Extract variable], type name of new variable to create, enjoy
> 
> This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/contextmenumutator.cpp PRE-CREATION 
>   refactoring/error.h PRE-CREATION 
>   refactoring/error.cpp PRE-CREATION 
>   refactoring/extractvariablerefactoring.h PRE-CREATION 
>   refactoring/extractvariablerefactoring.cpp PRE-CREATION 
>   refactoring/refactoringcontext.h PRE-CREATION 
>   refactoring/refactoringcontext.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/test_extractvariable.h PRE-CREATION 
>   tests/test_extractvariable.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124598/diff/
> 
> 
> Testing
> -------
> 
> Tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150810/ad3f70ef/attachment-0001.html>