Review Request 124598: Extract variable refactoring

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at
Thu Aug 13 23:58:54 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Sie 14, 2015, 1:58 rano)

Review request for KDevelop.


Small fixes

remove (global) Error, use TU-local (in anonymous namespace) Error in place of use.
`error.h` was very old file created at the begining (to workaround exceptions for `Refactoring::invoke`). It was empty enumeration outside of git up the the point of first use in this refactoring. But it turns out that this doesn't have to be global. File was removed, enumeration moved to implementation of this refactoring. It also removes branch from runtime code (branch is at compile time instead - in ADL)

Repository: kdev-clang


Extract variable refactoring

Select some expression, right click, [Extract variable], type name of new variable to create, enjoy

This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)

Diffs (updated)

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/contextmenumutator.cpp PRE-CREATION 
  refactoring/extractvariablerefactoring.h PRE-CREATION 
  refactoring/extractvariablerefactoring.cpp PRE-CREATION 
  refactoring/refactoringcontext.h PRE-CREATION 
  refactoring/refactoringcontext.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
  tests/test_extractvariable.h PRE-CREATION 
  tests/test_extractvariable.cpp PRE-CREATION 



Tests included


Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list