Review Request 124598: Extract variable refactoring

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at
Mon Aug 3 18:33:55 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated Sie 3, 2015, 8:33 po poĊ‚udniu)

Review request for KDevelop.


Well, it wasn't so good. This patch fixes (lack of) initialization inside of `ExprRangeRefactoring` (`RefactoringManager` helper).

I also have issues with menus not being destroyed... (`ContextMenuMutator` or near)

Repository: kdev-clang


Extract variable refactoring

Select some expression, right click, [Extract variable], type name of new variable to create, enjoy

This is "local refactoring" - RefactoringContext is not used in `invoke` (thus it is fast)

Diffs (updated)

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/contextmenumutator.cpp PRE-CREATION 
  refactoring/error.h PRE-CREATION 
  refactoring/error.cpp PRE-CREATION 
  refactoring/extractvariablerefactoring.h PRE-CREATION 
  refactoring/extractvariablerefactoring.cpp PRE-CREATION 
  refactoring/refactoringcontext.h PRE-CREATION 
  refactoring/refactoringcontext.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
  tests/test_extractvariable.h PRE-CREATION 
  tests/test_extractvariable.cpp PRE-CREATION 



Tests included


Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list