Review Request 124624: Extract function refactoring

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124624/#review83629
-----------------------------------------------------------

Ship it!



refactoring/documentcache.cpp (line 78)
<https://git.reviewboard.kde.org/r/124624/#comment57874>

    what is "everything"?



refactoring/extractfunctionrefactoring.h (line 43)
<https://git.reviewboard.kde.org/r/124624/#comment57875>

    use the name `create` instead of `make`


- Milian Wolff


On Aug. 5, 2015, 8:23 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124624/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract function (from expression) refactoring
> 
> This refactoring extracts function from expression. More advanced version would also allow extracting from statements (but have to handle input _and_ __output__ variables).
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/documentcache.cpp PRE-CREATION 
>   refactoring/extractfunctionrefactoring.h PRE-CREATION 
>   refactoring/extractfunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/refactoringenvironment.h PRE-CREATION 
>   tests/refactoringenvironment.cpp PRE-CREATION 
>   tests/test_extractfunction.h PRE-CREATION 
>   tests/test_extractfunction.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124624/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150809/1f8c10bb/attachment-0001.html>