Review Request 124624: Extract function refactoring

Maciej Poleski d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Wed Aug 5 20:23:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124624/
-----------------------------------------------------------

(Updated Sie 5, 2015, 10:23 po poĊ‚udniu)


Review request for KDevelop.


Changes
-------

Fixed FIXME and TODO
Small improvements (special cased 'this' pointer, generate static member function instead of instance if possible)

Unit tests (and extension to UTF to enable this)

and I still have a blackout...


Repository: kdev-clang


Description (updated)
-------

Extract function (from expression) refactoring

This refactoring extracts function from expression. More advanced version would also allow extracting from statements (but have to handle input _and_ __output__ variables).


Diffs (updated)
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/documentcache.cpp PRE-CREATION 
  refactoring/extractfunctionrefactoring.h PRE-CREATION 
  refactoring/extractfunctionrefactoring.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
  tests/refactoringenvironment.h PRE-CREATION 
  tests/refactoringenvironment.cpp PRE-CREATION 
  tests/test_extractfunction.h PRE-CREATION 
  tests/test_extractfunction.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124624/diff/


Testing (updated)
-------

Unit tests included


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150805/a177ddd6/attachment.html>


More information about the KDevelop-devel mailing list