Review Request 124624: Extract function refactoring

[Maciej Poleski]

> On Sie 9, 2015, 11:27 po południu, Milian Wolff wrote:
> >

There is a few more reviews pending...


> On Sie 9, 2015, 11:27 po południu, Milian Wolff wrote:
> > refactoring/documentcache.cpp, line 78
> > <https://git.reviewboard.kde.org/r/124624/diff/2/?file=390463#file390463line78>
> >
> >     what is "everything"?

it shouldn't be there. There is other review which fixes this bug (https://git.reviewboard.kde.org/r/124631/)


- Maciej


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124624/#review83629
-----------------------------------------------------------


On Sie 5, 2015, 10:23 po południu, Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124624/
> -----------------------------------------------------------
> 
> (Updated Sie 5, 2015, 10:23 po południu)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Extract function (from expression) refactoring
> 
> This refactoring extracts function from expression. More advanced version would also allow extracting from statements (but have to handle input _and_ __output__ variables).
> 
> 
> Diffs
> -----
> 
>   refactoring/CMakeLists.txt PRE-CREATION 
>   refactoring/documentcache.cpp PRE-CREATION 
>   refactoring/extractfunctionrefactoring.h PRE-CREATION 
>   refactoring/extractfunctionrefactoring.cpp PRE-CREATION 
>   refactoring/refactoringmanager.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/refactoringenvironment.h PRE-CREATION 
>   tests/refactoringenvironment.cpp PRE-CREATION 
>   tests/test_extractfunction.h PRE-CREATION 
>   tests/test_extractfunction.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124624/diff/
> 
> 
> Testing
> -------
> 
> Unit tests included
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150809/9a51c883/attachment.html>