Review Request 123279: Add color tab feature
Kevin Funk
kfunk at kde.org
Mon Aug 3 12:06:48 UTC 2015
> On May 5, 2015, 8:33 p.m., Milian Wolff wrote:
> > Hey! Thanks for the update. This looks pretty good now, I think we should give it a try. But please make this new feature off-by-default.
> >
> > I've also marked a bunch of style issues in this review. Please take that into account for future patches if possible. Since our old codebase is not really good at being consistent, I could also take care of fixing these issues myself if you prefer. Do you have a KDE account btw? If not, then we'll need to push it on your behalf anyways and could do these minor cleanups.
>
> Milian Wolff wrote:
> Ping, any news on this?
@Sebastien: Are you planning to work on this? I'd really like to see this cool feature in KDevelop!
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123279/#review79916
-----------------------------------------------------------
On April 29, 2015, 8:17 p.m., Sebastien Speierer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123279/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:17 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
> This feature was asked by several users on the KDE bugtracking system.
>
>
> Diffs
> -----
>
> interfaces/iprojectcontroller.h 86c2dfd
> plugins/projectmanagerview/projectmodelitemdelegate.cpp 69fd6c4
> plugins/projectmanagerview/projecttreeview.h 6512157
> plugins/projectmanagerview/projecttreeview.cpp dbd25ff
> shell/mainwindow.h ae22648
> shell/mainwindow.cpp 8757942
> shell/plugincontroller.cpp 362bfb0
> shell/projectcontroller.h 062e200
> shell/projectcontroller.cpp 50bdce4
> shell/settings/uiconfig.kcfg b168294
> shell/settings/uiconfig.ui a0d76de
> shell/uicontroller.cpp 2108ff2
> sublime/container.h 9049f55
> sublime/container.cpp 4444077
>
> Diff: https://git.reviewboard.kde.org/r/123279/diff/
>
>
> Testing
> -------
>
> I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.
>
>
> File Attachments
> ----------------
>
> Screenshot01
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png
> Screenshot #2 project_manager
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/79fa321d-3952-43d7-83e8-4af07116c82f__kdevelop5_env_2.png
> Dark scheme color handled
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/8125d1e3-fb1d-4268-a100-c47523b9aa8e__kdevelop5_env_3.png
>
>
> Thanks,
>
> Sebastien Speierer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150803/d03b6a8d/attachment.html>
More information about the KDevelop-devel
mailing list