<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123279/">https://git.reviewboard.kde.org/r/123279/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2015, 8:33 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hey! Thanks for the update. This looks pretty good now, I think we should give it a try. But please make this new feature off-by-default.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've also marked a bunch of style issues in this review. Please take that into account for future patches if possible. Since our old codebase is not really good at being consistent, I could also take care of fixing these issues myself if you prefer. Do you have a KDE account btw? If not, then we'll need to push it on your behalf anyways and could do these minor cleanups.</p></pre>
</blockquote>
<p>On July 25th, 2015, 10:40 p.m. UTC, <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ping, any news on this?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Sebastien: Are you planning to work on this? I'd really like to see this cool feature in KDevelop!</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On April 29th, 2015, 8:17 p.m. UTC, Sebastien Speierer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Sebastien Speierer.</div>
<p style="color: grey;"><i>Updated April 29, 2015, 8:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds a checkbox in the KDevelop setting that allows KDevelop to color the tabs (of the open files) depending of their project.
This feature was asked by several users on the KDE bugtracking system.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested the feature (open file before/after enable the coloring, tried to open files from several different projects,...), the implementation seems robust.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iprojectcontroller.h <span style="color: grey">(86c2dfd)</span></li>
<li>plugins/projectmanagerview/projectmodelitemdelegate.cpp <span style="color: grey">(69fd6c4)</span></li>
<li>plugins/projectmanagerview/projecttreeview.h <span style="color: grey">(6512157)</span></li>
<li>plugins/projectmanagerview/projecttreeview.cpp <span style="color: grey">(dbd25ff)</span></li>
<li>shell/mainwindow.h <span style="color: grey">(ae22648)</span></li>
<li>shell/mainwindow.cpp <span style="color: grey">(8757942)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(362bfb0)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(062e200)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(50bdce4)</span></li>
<li>shell/settings/uiconfig.kcfg <span style="color: grey">(b168294)</span></li>
<li>shell/settings/uiconfig.ui <span style="color: grey">(a0d76de)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(2108ff2)</span></li>
<li>sublime/container.h <span style="color: grey">(9049f55)</span></li>
<li>sublime/container.cpp <span style="color: grey">(4444077)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123279/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/c544c7ee-765e-4851-be5c-86d5b2241dab__kdevelop5_env_1.png">Screenshot01</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/79fa321d-3952-43d7-83e8-4af07116c82f__kdevelop5_env_2.png">Screenshot #2 project_manager</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/29/8125d1e3-fb1d-4268-a100-c47523b9aa8e__kdevelop5_env_3.png">Dark scheme color handled</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>